Repository navigation
fix(web): stabilize shared components and editor controls - #59
Merged
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📜 Recent review details
📝 Summary
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 15 functions across 20 files. | Write docstrings for the functions missing them to satisfy the coverage threshold. |
-
Check name Status Explanation Description check The description accurately summarizes the changes, preserved behavior, tests, validation results, and known lint status. Title check The title clearly summarizes the primary changes to stabilize shared components and editor controls. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
- Fix all pre-merge checks with AI
✨ Finishing Touches: 💡 1
-
📝 Generate docstrings: 💡
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
A rabbit checks the context, then hops along the trail.
A button gets a clearer name; a filter finds its way.
Tests open dialogs, then close them with care.
The hooks find their home, and the labels stay.
I nibble one last comment, and bound away.
Comment @coderabbitai help to get the list of available commands.
Contributor
Author
|
@coderabbitai full review |
✅ Action performedFull review finished. |
5 of 8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User information fields currently remount on unrelated parent updates, clearing text selection. Keep the existing InfoItem component at module scope and add a regression for field identity, selection, zero values and a single API request.
Separate existing verification/settings contexts and hooks, and quota-filter utilities, from component modules. Preserve the verification feature exports, gate cancellation/rejection behavior, API-token scope, method identity and settings defaults. Remove two unused lint-disable comments.
Give the pricing editor mode selector its translated accessible name and select it by role/name. Collect all optional price fields with one standard label query instead of repeated whole-DOM scans. Reuse alert-test controls and scope actions to the current confirmation dialog. Preserve every price/count/expression and financial revision/request/disabled-state assertion. Update the existing continuation-test stub to the extracted hook without changing its assertions.
Validation: 539 frontend tests pass across 34 processes; four new focused regressions, all 60 editor tests, 21 alert tests and the existing 18 continuation tests pass. User-field and missing-mode-label regressions fail on the original code. Typecheck, Prettier for all 22 changed files, ESLint for 20 files without carry-forward diagnostics, production build and both Tailwind CSS checks pass. Test mirrors contain 360 tests and two workflow files.
This is the first of three lint batches: global lint improves from 69 errors / 9 warnings to 60 errors / 1 warning, with no added diagnostics. Two changed files retain five already-recorded ref/effect errors; the global check remains failing. No rules or deadlines were relaxed. Initial runs retained editor and alert timeouts and a stale stub-path failure; the final full run passes after fixing repeated queries and updating that stub.
Compared with pinned New API 718a4e7f9751c5bf1958747cd0c2c895e2b937d4 using immutable GitHub tree/blob evidence. Its oxlint/Vitest rules differ. Implemented independently from existing MAX code; no upstream source, tooling or dependencies were transplanted, and attribution remains intact.
Stacked on windows-test-stability (PR #58); 22 changed files. Backend, financial mutations, schema, permission policy and dependency versions are unchanged. Real database/provider/browser/race coverage is not claimed.