Repository navigation
fix(dfns): name STO's period field stress_period_data - #398
Merged
Merged
Conversation
The dev2 migration collapses STO's STEADY-STATE/TRANSIENT keywords into one untagged string per period. Name it stress_period_data, like every other package's period data, instead of storage, so consumers can treat it as an ordinary single-field period block without a rename table. Applies to chf-sto, gwf-sto, olf-sto and swf-sto. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
wpbonelli
marked this pull request as ready for review
October 22, 2026 12:33
wpbonelli
added a commit
that referenced
this pull request
Oct 22, 2026
Followup to #398, rename every fill-forward stress period data list field to stress_period_data. We already made these names consistent in flopy4 with some hardcoding, which this makes unnecessary. Period blocks with multiple fields (e.g. grid-array packages) and period blocks that don't fill forward (e.g. TDIS and ATS) are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The DFN migration collapses STO's STEADY-STATE/TRANSIENT keywords into a string field. Name it stress_period_data, like other packages' period data. Applies to chf-sto, gwf-sto, olf-sto and swf-sto.