Skip to content

fix: account search typeahead not working#833

Merged
sven-n merged 2 commits into
MUnique:masterfrom
eduardosmaniotto:bugfix/account-search
Jul 17, 2026
Merged

fix: account search typeahead not working#833
sven-n merged 2 commits into
MUnique:masterfrom
eduardosmaniotto:bugfix/account-search

Conversation

@eduardosmaniotto

@eduardosmaniotto eduardosmaniotto commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

The search input on the Accounts page had three differences from the standard search pattern used across EditConfigGrid, Plugins, and other pages:

  • @Bind:event="oninput" was missing — search only triggered on blur/Enter instead of on every keystroke
  • Placeholder was hardcoded English instead of using the localized @Resources.Search
  • autofocus and the small CSS class** were missing
  • Add debouncer
  • Fix build warnings

@gemini-code-assist

Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request standardizes the search input on the Accounts page to align with the design patterns used across the rest of the application. These changes improve the user experience by enabling real-time search, ensuring proper localization, and refining the visual presentation of the search component.

Highlights

  • Real-time search functionality: Added @Bind:event="oninput" to the search input to trigger filtering on every keystroke instead of only on blur or enter.
  • Localization and UI consistency: Updated the input placeholder to use the localized @Resources.Search string and applied the small CSS class to match the standard application search pattern.
  • UX improvements: Added autofocus to the search input and adjusted the table header colspan to ensure proper layout alignment.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the search input in the Accounts razor page to bind on the oninput event for real-time filtering, adds autofocus, and updates the placeholder. Feedback highlights a performance concern where binding to oninput triggers database queries on every keystroke, and suggests implementing debouncing or reverting to the default binding to prevent high database load.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread src/Web/AdminPanel/Pages/Accounts.razor
@sven-n
sven-n merged commit 8f2b32d into MUnique:master Jul 17, 2026
2 checks passed
@eduardosmaniotto
eduardosmaniotto deleted the bugfix/account-search branch July 17, 2026 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants