Skip to content

fix: account search typeahead not working #833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sven-n merged 2 commits into from
Jul 17, 2026
Merged

fix: account search typeahead not working #833

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0f0ca4
fix: account search typeahead not working
eduardosmaniotto Jul 17, 2026
aba3fd4
add debouncer and fix build warnings
eduardosmaniotto Jul 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/Web/AdminPanel/Pages/Accounts.razor
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,12 @@
<th class="col-2">@Resources.Action</th>
</TableHeader>
<FilterHeader>
<th colspan="3">
<th colspan="4">
<div class="input-group">
<span class="input-group-text"><span class="oi oi-magnifying-glass" aria-hidden="true"></span></span>
<input type="search" class="form-control" placeholder="Search by Account or Character Name..." @bind="@this._accountService.SearchFilter"/>
<input class="form-control small" type="search" autofocus @bind="@this._accountService.SearchFilter" @bind:event="oninput" placeholder="@Resources.Search ..."/>
Comment thread
eduardosmaniotto marked this conversation as resolved.
</div>
</th>
<th></th>
</FilterHeader>
<ItemTemplate Context="item">
<td>@item.LoginName</td>
Expand Down
38 changes: 29 additions & 9 deletions src/Web/Shared/Services/AccountService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,19 +6,23 @@ namespace MUnique.OpenMU.Web.Shared.Services;

using System.ComponentModel.DataAnnotations;
using System.Diagnostics.CodeAnalysis;
using MUnique.OpenMU.Web.Shared.Components.Modal;
using MUnique.OpenMU.DataModel.Entities;
using MUnique.OpenMU.Persistence;
using MUnique.OpenMU.Web.Shared.Components;
using MUnique.OpenMU.Web.Shared.Components.Form.Modal;
using MUnique.OpenMU.Web.Shared.Components.Modal;
using MUnique.OpenMU.Web.Shared.Properties;

/// <summary>
/// Service for <see cref="Account"/>s.
/// </summary>
public class AccountService : IDataService<Account>, ISupportDataChangedNotification
public class AccountService : IDataService<Account>, ISupportDataChangedNotification, IDisposable
{
private readonly IDataSource<Account> _dataSource;
private readonly IModalService _modalService;
private readonly Debouncer _debouncer = new(300);

private string _searchFilter = string.Empty;

/// <summary>
/// Initializes a new instance of the <see cref="AccountService"/> class.
Expand All @@ -31,7 +35,8 @@ public AccountService(IDataSource<Account> dataSource, IModalService modalServic
this._modalService = modalService;
}

private string _searchFilter = string.Empty;
/// <inheritdoc />
public event EventHandler? DataChanged;

/// <summary>
/// Gets or sets the search filter query.
Expand All @@ -45,14 +50,19 @@ public string SearchFilter
if (this._searchFilter != newValue)
{
this._searchFilter = newValue;
this.RaiseDataChanged();
if (string.IsNullOrEmpty(newValue))
{
this._debouncer.Cancel();
this.DataChanged?.Invoke(this, EventArgs.Empty);
}
else
{
_ = this._debouncer.DebounceAsync(this.RaiseDataChangedAsync);
}
}
}
}

/// <inheritdoc />
public event EventHandler? DataChanged;

/// <summary>
/// Returns a slice of the account list, defined by an offset and a count.
/// </summary>
Expand Down Expand Up @@ -138,11 +148,21 @@ public async Task CreateNewInModalDialogAsync()
item.SecurityCode = accountParameters.SecurityCode;
item.RegistrationDate = DateTime.UtcNow;
await context.SaveChangesAsync().ConfigureAwait(false);
this.RaiseDataChanged();
this.DataChanged?.Invoke(this, EventArgs.Empty);
}
}

private void RaiseDataChanged() => this.DataChanged?.Invoke(this, EventArgs.Empty);
/// <inheritdoc />
public void Dispose()
{
this._debouncer.Dispose();
}

private Task RaiseDataChangedAsync()
{
this.DataChanged?.Invoke(this, EventArgs.Empty);
return Task.CompletedTask;
}

/// <summary>
/// Parameters for the account creation which is used for the user interface.
Expand Down