fix: duplicate rows in deserialized aggregate collections

[eduardosmaniotto]

Fix: Duplicate rows in deserialized aggregate collections

The custom ReferenceResolvingConverter<T>'s generated adder delegates unconditionally called collection.Add(item). When the JSON deserializer encounters the same $id a second time (e.g., a PowerUpDefinitionValue embedded under RawDuration and later referenced by $ref from RawBoost), the item was added again to the backing List<T>, producing a duplicate in memory despite the database having only one row.

Fixed by adding a Contains guard before Add, matching the pattern already used in GenericRepositoryBase.LoadCollectionAsync.

Elf Soldier buff updates

NpcInitialization.cs and AddElfSoldierBuffPlugIn.cs updated to add the missing AggregateType.AddFinal for the damage boost. AddElfSoldierBuffPlugIn.cs also hardened to find-or-create the MagicEffectDefinition instead of always creating new ones.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a bug where duplicate rows were being created in aggregate collections during JSON deserialization due to unconditional Add calls. It also includes refinements to the Elf Soldier buff initialization logic to ensure consistency and prevent redundant definitions.

Highlights

• Deserialization Fix: Updated ReferenceResolvingConverter to include a Contains check before adding items to aggregate collections, preventing duplicate entries during JSON deserialization.
• Elf Soldier Buff Updates: Hardened the Elf Soldier buff initialization to prevent duplicate creation and ensured the damage boost correctly uses AggregateType.AddFinal.

New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the initialization of the Elf Soldier Buff to prevent duplicate creation and adds the missing AggregateType.AddFinal to the damage boost configuration. It also updates ReferenceResolvingConverter to check if a collection already contains an item before adding it during deserialization. The review feedback highlights critical issues: first, the database update logic will skip applying the AggregateType fix to existing databases if the buff already exists; second, the dynamic expression trees in ReferenceResolvingConverter risk throwing runtime exceptions (ArgumentException and NullReferenceException) due to type mismatches and reflection limitations on inherited interfaces. Code suggestions are provided to resolve these issues.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.