Repository navigation
Stabilize MarkEditMac context-menu tests - #1817
Merged
Merged
Conversation
Co-authored-by: cyanzhong <6745066+cyanzhong@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job MarkEditMac
Stabilize MarkEditMac context-menu tests
Oct 15, 2026
cyanzhong
marked this pull request as ready for review
October 15, 2026 11:55
cyanzhong
approved these changes
Oct 15, 2026
Contributor
|
@copilot Test still fails, try understand this better. |
Co-authored-by: cyanzhong <6745066+cyanzhong@users.noreply.github.com>
Contributor
Author
The logs show both ContextMenuTests passed; the job failed afterward because those tests only ordered out their NSPanel instances, leaving them in NSApp.windows and failing EditorDocumentTests.setUp(). I changed both teardowns to close the panels and reverted the unrelated polling change in b53c62a. |
cyanzhong
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MarkEditMac job failed in context-menu tests because the menu could still be opening when the test helper’s one-shot check ran.
Checklist