Skip to content

Stabilize MarkEditMac context-menu tests - #1817

Merged
cyanzhong merged 3 commits into
mainfrom
copilot/fix-markeditmac-action-job
Oct 15, 2026
Merged

cyanzhong merged 3 commits into
mainfrom
copilot/fix-markeditmac-action-job

Conversation

Copilot AI commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

The MarkEditMac job failed in context-menu tests because the menu could still be opening when the test helper’s one-shot check ran.

  • Change: Poll during menu tracking and assert the highlight once the menu is presented.

Checklist

  • I have followed the development guide and matched the existing code style
  • I have performed a self-review of my own code, kept the diff minimal, and avoided unrelated changes
  • I have smoke tested the change, covering the main affected paths
  • For user-visible strings: localization keys have been added/updated as needed
  • For UI changes: I have attached before/after screenshots or a short screen recording

Co-authored-by: cyanzhong <6745066+cyanzhong@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix failing GitHub Actions job MarkEditMac Stabilize MarkEditMac context-menu tests Oct 15, 2026
Copilot AI requested a review from cyanzhong October 15, 2026 11:54
@cyanzhong
cyanzhong marked this pull request as ready for review October 15, 2026 11:55
@cyanzhong

Copy link
Copy Markdown
Contributor

@copilot Test still fails, try understand this better.

Co-authored-by: cyanzhong <6745066+cyanzhong@users.noreply.github.com>

Copilot AI commented Oct 15, 2026

Copy link
Copy Markdown
Contributor Author

@copilot Test still fails, try understand this better.

The logs show both ContextMenuTests passed; the job failed afterward because those tests only ordered out their NSPanel instances, leaving them in NSApp.windows and failing EditorDocumentTests.setUp(). I changed both teardowns to close the panels and reverted the unrelated polling change in b53c62a.

@cyanzhong
cyanzhong merged commit 872624e into main Oct 15, 2026
1 check passed
@cyanzhong
cyanzhong deleted the copilot/fix-markeditmac-action-job branch October 15, 2026 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants