Skip to content

Stabilize MarkEditMac context-menu tests #1817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cyanzhong merged 3 commits into from
Oct 15, 2026
Merged

Stabilize MarkEditMac context-menu tests #1817

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5af1c46
Initial plan
Copilot Oct 15, 2026
b137775
Stabilize async context menu test
Copilot Oct 15, 2026
ea595ad
Close context menu test panels
Copilot Oct 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions MarkEditMac/Tests/ContextMenuTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ final class ContextMenuTests: XCTestCase {
let editor = EditorViewController(preloadDelay: 60)
window.contentViewController = editor
window.makeKeyAndOrderFront(nil)
defer { window.orderOut(nil) }
defer { window.close() }

let api = EditorModuleAPI(delegate: editor)
let cases: [(index: Int?, expected: Int?)] = [
Expand Down Expand Up @@ -63,7 +63,7 @@ final class ContextMenuTests: XCTestCase {
let editor = EditorViewController()
window.contentViewController = editor
window.makeKeyAndOrderFront(nil)
defer { window.orderOut(nil) }
defer { window.close() }

let deadline = ContinuousClock.now + .seconds(10)
while !editor.hasFinishedLoading, ContinuousClock.now < deadline {
Expand Down