Repository navigation
ci: arm the automatic code review trigger - #113
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #113 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 69 69
Lines 2187 2187
Branches 272 272
=========================================
Hits 2187 2187 Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code review bot has never reviewed a pull request here automatically.
code-review.ymlshipped with itsworkflow_runtrigger commented out and a banner explaining why: the rollout was staged so a person could read the first review before every open pull request got one.Only
MarketData-App/apiandMarketDataApp/sdk-pywere ever armed.sdk-csharp, along with sdk-go, sdk-js, sdk-java, sdk-csharp and sdk-php, has been dispatch-only ever since — a push starts nothing.This removes the comment markers and the banner.
One correction to the template
The commented block named
workflows: ["Tests", "Lint"]. This repository has no workflow namedLint—Testsis its only pull-request workflow. Aworkflow_runname that matches nothing never fires and reports nothing, soLintwould have been silent dead weight. The armed trigger names["Tests"].What to expect
require_ci_greenrefuses a commit whose checks are still running, so a push-triggered review would find CI pending, skip, and never come back — reporting success having done nothing.policy.ymlhere isbackends: [codex, claude],mode: fallback,gate: true. Reviews borrow the shared Codex credential; it sat at about 3% occupancy over the last seven days, so there is headroom.CODE_REVIEW_APP_PRIVATE_KEY,CLAUDE_CODE_OAUTH_TOKEN) are already set on this repository.Every successful review will report
claude unavailablein its footer. That is expected undermode: fallback— Codex answers first and Claude is never invoked. The job log now says so explicitly.