Skip to content

ci: arm the automatic code review trigger - #113

Merged
MarketDataApp merged 1 commit into
mainfrom
ci/arm-the-code-review-trigger
Sep 22, 2026
Merged

MarketDataApp merged 1 commit into
mainfrom
ci/arm-the-code-review-trigger

Conversation

@MarketDataApp

Copy link
Copy Markdown
Owner

The code review bot has never reviewed a pull request here automatically. code-review.yml shipped with its workflow_run trigger commented out and a banner explaining why: the rollout was staged so a person could read the first review before every open pull request got one.

Only MarketData-App/api and MarketDataApp/sdk-py were ever armed. sdk-csharp, along with sdk-go, sdk-js, sdk-java, sdk-csharp and sdk-php, has been dispatch-only ever since — a push starts nothing.

This removes the comment markers and the banner.

One correction to the template

The commented block named workflows: ["Tests", "Lint"]. This repository has no workflow named Lint — Tests is its only pull-request workflow. A workflow_run name that matches nothing never fires and reports nothing, so Lint would have been silent dead weight. The armed trigger names ["Tests"].

What to expect

  • The trigger is CI's completion, not the push. require_ci_green refuses a commit whose checks are still running, so a push-triggered review would find CI pending, skip, and never come back — reporting success having done nothing.
  • Arming is not retroactive. Open pull requests get their first review when their CI next completes, not all at once.
  • policy.yml here is backends: [codex, claude], mode: fallback, gate: true. Reviews borrow the shared Codex credential; it sat at about 3% occupancy over the last seven days, so there is headroom.
  • Both required secrets (CODE_REVIEW_APP_PRIVATE_KEY, CLAUDE_CODE_OAUTH_TOKEN) are already set on this repository.

Every successful review will report claude unavailable in its footer. That is expected under mode: fallback — Codex answers first and Claude is never invoked. The job log now says so explicitly.

@codecov

codecov Bot commented Sep 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (3438f7f) to head (8a354c2).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #113   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           69        69           
  Lines         2187      2187           
  Branches       272       272           
=========================================
  Hits          2187      2187           

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3438f7f...8a354c2. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MarketDataApp
MarketDataApp merged commit 1876a27 into main Sep 22, 2026
10 checks passed
@MarketDataApp
MarketDataApp deleted the ci/arm-the-code-review-trigger branch September 22, 2026 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant