Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 10 additions & 16 deletions .github/workflows/code-review.yml
Original file line number Diff line number Diff line change
@@ -1,22 +1,16 @@
name: Code review

# DISPATCH ONLY FOR NOW, DELIBERATELY.
#
# The automatic trigger is written out below and commented. It is held back so
# the first review on this repository is read by a person before every open
# pull request gets one: this repository has never been reviewed by the bot, and
# whether the rules say useful things about sdk-csharp is the one thing nobody
# has measured yet.
#
# TO ARM IT: delete the `workflow_run` comment markers below, and delete this
# banner. Nothing else changes. Read docs/setup.md section 4 in
# MarketData-App/code-review-bot first -- it explains why the trigger is CI's
# completion and not the push.
on:
# workflow_run:
# # The `name:` of this repository's pull-request CI, not its filename.
# workflows: ["Tests", "Lint"]
# types: [completed]
# CI'S COMPLETION, not the push. `require_ci_green` refuses a commit whose
# checks are still running, so a push-triggered review would find CI pending,
# skip, and never come back -- reporting success having done nothing.
workflow_run:
# The workflow's `name:`, never its filename. `Tests` is this repository's
# ONLY pull-request workflow. The template this file came from also listed
# `Lint`, which does not exist here; a name matching no workflow never
# fires, so it was silent dead weight rather than a second trigger.
workflows: ["Tests"]
types: [completed]
issue_comment:
types: [created]
workflow_dispatch:
Expand Down
Loading