Repository navigation
Split horizontal deltas - #243
Open
blawrence-ont wants to merge 2 commits into
Open
blawrence-ont wants to merge 2 commits into
blawrence-ont wants to merge 2 commits into
Conversation
Initially this was just removing the duplicate in/out args, but we can just pass the block and update it.
This gives a noticeable perf increase.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is just the performance improvements from #214 rebased onto
masterwith some minor cleanups, since that PR hasn't seen any activity in a while. I don't know what the original benchmarks used in that PR are, but in our project we see a noticeable performance increase from these changes.