Skip to content

Expose scoped tool lifecycle and plans through ACP - #135

Closed
Maximooch wants to merge 1 commit into
feat/acp-baselinefrom
feat/acp-tool-events
Closed

Maximooch wants to merge 1 commit into
feat/acp-baselinefrom
feat/acp-tool-events

Conversation

@Maximooch

Copy link
Copy Markdown
Owner

Stacked on Fix ACP resource inputs and Windows stdio baseline (#134). Penguin's ACP client previously saw only text, even when the runtime executed tools. This bridges the existing session-scoped action/action-result and todo events into ACP tool starts, terminal results and plans. Stable tool IDs survive, duplicate results are suppressed, output is bounded, and interrupted tools are finalized before the prompt returns. Unrelated-session and late events are ignored; subscriptions are removed on adapter shutdown.

File locations use absolute paths within the session workspace. Returned diffs remain rendered diff text; this does not pretend to provide full-file native before/after snapshots. Fine-grained command streaming, native diff snapshots and child-session integration remain follow-ups. No hidden reasoning or arbitrary runtime metadata is forwarded.

Validation: 23 focused tests pass including actual CLI/serve subprocess wire validation with a fake core producing tool events; event ordering, cross-session isolation, duplicate suppression, plans, cancellation finalization and late-event rejection. Scoped Ruff and git diff --check pass. No real-editor smoke yet.

@vercel

vercel Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
penguin Ready Ready Preview Oct 28, 2026 4:59am UTC

@coderabbitai

coderabbitai Bot commented Oct 28, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Maximooch

Copy link
Copy Markdown
Owner Author

Integrated with preserved commit history through #161 (main commit abd8a66). Closing this stacked review after verifying its current head is an ancestor of main.

@Maximooch Maximooch closed this Oct 28, 2026

This branch was successfully deployed

1 active deployment
Preview — 96960e18 Deployed Oct 28, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant