Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Owner
Author
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on Fix ACP resource inputs and Windows stdio baseline (#134). Penguin's ACP client previously saw only text, even when the runtime executed tools. This bridges the existing session-scoped action/action-result and todo events into ACP tool starts, terminal results and plans. Stable tool IDs survive, duplicate results are suppressed, output is bounded, and interrupted tools are finalized before the prompt returns. Unrelated-session and late events are ignored; subscriptions are removed on adapter shutdown.
File locations use absolute paths within the session workspace. Returned diffs remain rendered diff text; this does not pretend to provide full-file native before/after snapshots. Fine-grained command streaming, native diff snapshots and child-session integration remain follow-ups. No hidden reasoning or arbitrary runtime metadata is forwarded.
Validation: 23 focused tests pass including actual CLI/serve subprocess wire validation with a fake core producing tool events; event ordering, cross-session isolation, duplicate suppression, plans, cancellation finalization and late-event rejection. Scoped Ruff and git diff --check pass. No real-editor smoke yet.