Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Owner
Author
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on Expose scoped tool lifecycle and plans through ACP (#135). ACP-created sessions now persist immutable workspace ownership and the visible user/tool/assistant update history inside Penguin's native session store. Clients can list, load with ordered replay before acknowledgement, resume without replay, and close without deleting history. Other workspaces and legacy sessions without ACP ownership are not exposed. Interrupted tool entries recover as failed without re-execution. Shared-core lifecycle and prompt operations remain serialized.
The pinned SDK gates resume/close behind its historical unstable switch even though current v1 docs include them; the stdio adapter enables that dispatcher switch, while unimplemented methods remain unadvertised. Deletion remains a follow-up because the SDK omits that route. This is not a claim of complete v1 parity.
Validation: 28 aggregate ACP tests pass; native SessionManager disk restart and core message continuation; full ordered visible replay; workspace/ID rejection; pagination; interrupted-tool repair; actual CLI subprocess restart/load/resume/close wire tests. Scoped Ruff and diff checks pass. Fake provider cores are used; no real-editor/provider smoke is claimed. History snapshots are currently persisted per update for correctness; high-volume performance remains an optimization opportunity.