Skip to content

Support validated image and embedded context in ACP - #137

Closed
Maximooch wants to merge 1 commit into
feat/acp-session-lifecyclefrom
feat/acp-rich-inputs
Closed

Maximooch wants to merge 1 commit into
feat/acp-session-lifecyclefrom
feat/acp-rich-inputs

Conversation

@Maximooch

Copy link
Copy Markdown
Owner

Stacked on Persist and restore workspace-scoped ACP sessions (#136). Adds native PNG/JPEG/WebP prompt images when the selected model advertises vision, plus embedded text and binary context. Binary inputs are validated and stored by content hash for future turns; images use Penguin's existing image_paths path. Embedded text is labeled untrusted context, binaries remain inert references, and no remote resource is automatically fetched.

Limits: 10 MiB per binary, 20 MiB aggregate attachments, 40 million image pixels. Invalid base64, mismatched media type, invalid image data and unsafe asset destinations fail before model execution. Attachments remain in native session storage after closing a session for continuation. This does not add audio or media conversion.

Validation: 35 aggregate ACP tests pass, including image data preservation, native model input, invalid/oversize inputs, embedded text/binary, and subprocess wire embedded context. Scoped Ruff and diff checks pass. Live provider/editor still not claimed.

@vercel

vercel Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
penguin Ready Ready Preview Oct 28, 2026 5:03am UTC

@coderabbitai

coderabbitai Bot commented Oct 28, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Maximooch

Copy link
Copy Markdown
Owner Author

Integrated with preserved commit history through #161 (main commit abd8a66). Closing this stacked review after verifying its current head is an ancestor of main.

@Maximooch Maximooch closed this Oct 28, 2026

This branch was successfully deployed

1 active deployment
Preview — 94a47c39 Deployed Oct 28, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant