Skip to content

Expose committed file snapshots as native ACP diffs - #143

Closed
Maximooch wants to merge 1 commit into
feat/acp-child-progressfrom
feat/acp-native-diffs
Closed

Maximooch wants to merge 1 commit into
feat/acp-child-progressfrom
feat/acp-native-diffs

Conversation

@Maximooch

Copy link
Copy Markdown
Owner

Stacked on experimental child-session support (#142). Canonical asynchronous edit tools now expose native ACP before/after file diffs from snapshots the authorized EditService transaction already held. No adapter-side reads are added. Events are emitted only after successful commit, keep the tool-call ID, and survive the final tool-result update. Failed edits produce no success diff.

Limits are explicit: whole-file snapshots up to 128 KiB combined and 16 files per tool call; larger or deleted files receive an omission notice instead of a misleading partial snapshot. Other diff output remains text. The observer is request scoped and reaches the existing edit worker through copied context.

Validation: 64 aggregate ACP/edit-service tests pass, including actual ToolManager async dispatch and EditService commit/failure checks, full old/new bytes, new-file semantics and snapshot size caps. Scoped Ruff and diff checks pass. ACP CI includes the new suite.

@vercel

vercel Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
penguin Ready Ready Preview Oct 28, 2026 5:31am UTC

@coderabbitai

coderabbitai Bot commented Oct 28, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Maximooch

Copy link
Copy Markdown
Owner Author

Integrated with preserved commit history through #161 (main commit abd8a66). Closing this stacked review after verifying its current head is an ancestor of main.

@Maximooch Maximooch closed this Oct 28, 2026

This branch was successfully deployed

1 active deployment
Preview — d55963b0 Deployed Oct 28, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant