Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Owner
Author
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on experimental child-session support (#142). Canonical asynchronous edit tools now expose native ACP before/after file diffs from snapshots the authorized EditService transaction already held. No adapter-side reads are added. Events are emitted only after successful commit, keep the tool-call ID, and survive the final tool-result update. Failed edits produce no success diff.
Limits are explicit: whole-file snapshots up to 128 KiB combined and 16 files per tool call; larger or deleted files receive an omission notice instead of a misleading partial snapshot. Other diff output remains text. The observer is request scoped and reaches the existing edit worker through copied context.
Validation: 64 aggregate ACP/edit-service tests pass, including actual ToolManager async dispatch and EditService commit/failure checks, full old/new bytes, new-file semantics and snapshot size caps. Scoped Ruff and diff checks pass. ACP CI includes the new suite.