Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Owner
Author
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and change
Background shell commands can outlive their initiating model turn without showing further output in ACP. Subscribe to the real scoped process runtime events and emit separate execution cards with retained output tails, capture errors and terminal status. The UI never consumes model output cursors or polls for progress. On reload, a missing owned handle is reported as unknown rather than successful.
Stack dependency:
stack/acp-progress-basecombines draft #143 native diffs and #144 child approval cleanup, on #142 and the explicitly documented #133 runtime integration. No PRs have been merged.Validation
os.set_blocking/pipe-capture failure in ProcessRuntime, being fixed in a separate reliability follow-up. This PR remains draft pending that dependency and the real Windows test.Historical child-process cards replay, but child process reconnection is not reconstructed without a live observed child. These are standard ACP tool cards, not a claim of client-specific task panels or terminal RPC parity.