Skip to content

Stream background process progress through ACP - #145

Closed
Maximooch wants to merge 1 commit into
stack/acp-progress-basefrom
feat/acp-process-progress
Closed

Maximooch wants to merge 1 commit into
stack/acp-progress-basefrom
feat/acp-process-progress

Conversation

@Maximooch

Copy link
Copy Markdown
Owner

Problem and change

Background shell commands can outlive their initiating model turn without showing further output in ACP. Subscribe to the real scoped process runtime events and emit separate execution cards with retained output tails, capture errors and terminal status. The UI never consumes model output cursors or polls for progress. On reload, a missing owned handle is reported as unknown rather than successful.

Stack dependency: stack/acp-progress-base combines draft #143 native diffs and #144 child approval cleanup, on #142 and the explicitly documented #133 runtime integration. No PRs have been merged.

Validation

  • ACP aggregate: 57 passed, 1 skipped on Windows Python 3.11.
  • Scoped Ruff and git diff checks passed.
  • Dedicated Linux/Windows Python 3.11/3.12 CI includes the new suite.
  • The actual subprocess producer test is temporarily skipped on Windows: it exposed os.set_blocking/pipe-capture failure in ProcessRuntime, being fixed in a separate reliability follow-up. This PR remains draft pending that dependency and the real Windows test.

Historical child-process cards replay, but child process reconnection is not reconstructed without a live observed child. These are standard ACP tool cards, not a claim of client-specific task panels or terminal RPC parity.

@vercel

vercel Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
penguin Ready Ready Preview Oct 28, 2026 5:37am UTC

@coderabbitai

coderabbitai Bot commented Oct 28, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Maximooch

Copy link
Copy Markdown
Owner Author

Integrated with preserved commit history through #161 (main commit abd8a66). Closing this stacked review after verifying its current head is an ancestor of main.

@Maximooch Maximooch closed this Oct 28, 2026

This branch was successfully deployed

1 active deployment
Preview — 1df9a2c4 Deployed Oct 28, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant