Skip to content

Add workspace-owned ACP session deletion - #147

Closed
Maximooch wants to merge 2 commits into
feat/acp-process-progressfrom
feat/acp-session-delete
Closed

Maximooch wants to merge 2 commits into
feat/acp-process-progressfrom
feat/acp-session-delete

Conversation

@Maximooch

Copy link
Copy Markdown
Owner

Change

Add the published optional session/delete method with indexed ACP workspace ownership checks, busy/active-child/background-process rejection, native conversation deletion and confined replay/attachment cleanup. Advertise deletion only when its handler is installed. SDK 0.12 has schema types but omits this route; an explicit schema-validated transport handler handles this one method while leaving normal routing to the official SDK. Notifications cannot cause deletion.

Depends on draft #145 (feat/acp-process-progress); no PRs merged.

Validation

12 session, deletion and real-CLI stdio tests pass on Windows Python 3.11, including malformed parameters, notification non-mutation, deletion/list behavior, ownership and busy rejection. Scoped Ruff and diff checks pass. Dedicated ACP CI includes the new tests.

No GUI-editor interoperability claim. The inherited real-process Windows capture test still awaits its separate runtime fix.

@vercel

vercel Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
penguin Ready Ready Preview Oct 28, 2026 5:41am UTC

@coderabbitai

coderabbitai Bot commented Oct 28, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Maximooch

Copy link
Copy Markdown
Owner Author

Integrated with preserved commit history through #161 (main commit abd8a66). Closing this stacked review after verifying its current head is an ancestor of main.

@Maximooch Maximooch closed this Oct 28, 2026

This branch was successfully deployed

1 active deployment
Preview — 2b8eee3c Deployed Oct 28, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant