Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Owner
Author
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Add the published optional session/delete method with indexed ACP workspace ownership checks, busy/active-child/background-process rejection, native conversation deletion and confined replay/attachment cleanup. Advertise deletion only when its handler is installed. SDK 0.12 has schema types but omits this route; an explicit schema-validated transport handler handles this one method while leaving normal routing to the official SDK. Notifications cannot cause deletion.
Depends on draft #145 (
feat/acp-process-progress); no PRs merged.Validation
12 session, deletion and real-CLI stdio tests pass on Windows Python 3.11, including malformed parameters, notification non-mutation, deletion/list behavior, ownership and busy rejection. Scoped Ruff and diff checks pass. Dedicated ACP CI includes the new tests.
No GUI-editor interoperability claim. The inherited real-process Windows capture test still awaits its separate runtime fix.