[Maximooch]

Change

The real Penguin question tool could wait indefinitely for its web UI while running through ACP. Route questions to form elicitation only when the client advertises it; validate chosen values before resolving the tool. Clients without forms receive a text question for their next message and the tool is rejected immediately. Cancel/close rejects pending questions and prevents late answers. Child requires_action counts both approvals and questions.

Depends on #147 (feat/acp-session-delete); no PRs merged. Form elicitation is explicitly optional/experimental in the pinned SDK, not a mandatory v1 parity claim. No URL/auth elicitation added.

Validation

14 focused tests pass: actual ActionExecutor question producer, accepted answer, unsupported-client fallback, invalid answers, cancellation/late replies, existing child approval cases, and real subprocess CLI form roundtrip through SDK. Earlier broader baseline/approval run passed29 tests before the3 invalid-answer cases were added. Scoped Ruff/diff checks pass; new suite added to dedicated ACP CI.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
penguin	Ready	Preview	Oct 28, 2026 5:41am UTC

[coderabbitai]

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

• Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[Maximooch]

Integrated with preserved commit history through #161 (main commit abd8a66). Closing this stacked review after verifying its current head is an ancestor of main.