Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Owner
Author
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to experimental ACP child sessions (#142). A child previously returned to running when any one approval resolved, and cancelling/closing a child could leave permission requests and network waiters alive. This tracks approval tasks per session, keeps requires_action until every pending request resolves, and denies requests before cancelling their waiters when a child stops, finishes, or closes. Closed adapters reject queued late requests. A late client allow result cannot revive an already denied request.
Validation: 26 child/approval/baseline tests pass. New regressions cover two simultaneous pending requests and cancel, parent-close, and child-finish while both are pending, including client replies that deliberately return allow after cancellation. Tests assert denied outcomes and no remaining waiter tasks. Scoped Ruff and diff checks pass.