Skip to content

Keep child approvals scoped to pending work and cancellation - #144

Closed
Maximooch wants to merge 1 commit into
feat/acp-child-progressfrom
fix/acp-child-approvals
Closed

Maximooch wants to merge 1 commit into
feat/acp-child-progressfrom
fix/acp-child-approvals

Conversation

@Maximooch

Copy link
Copy Markdown
Owner

Follow-up to experimental ACP child sessions (#142). A child previously returned to running when any one approval resolved, and cancelling/closing a child could leave permission requests and network waiters alive. This tracks approval tasks per session, keeps requires_action until every pending request resolves, and denies requests before cancelling their waiters when a child stops, finishes, or closes. Closed adapters reject queued late requests. A late client allow result cannot revive an already denied request.

Validation: 26 child/approval/baseline tests pass. New regressions cover two simultaneous pending requests and cancel, parent-close, and child-finish while both are pending, including client replies that deliberately return allow after cancellation. Tests assert denied outcomes and no remaining waiter tasks. Scoped Ruff and diff checks pass.

@vercel

vercel Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
penguin Ready Ready Preview Oct 28, 2026 5:34am UTC

@coderabbitai

coderabbitai Bot commented Oct 28, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Maximooch

Copy link
Copy Markdown
Owner Author

Integrated with preserved commit history through #161 (main commit abd8a66). Closing this stacked review after verifying its current head is an ancestor of main.

@Maximooch Maximooch closed this Oct 28, 2026

This branch was successfully deployed

1 active deployment
Preview — 9669f26e Deployed Oct 28, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant