Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Owner
Author
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Eligible single-file read/write prompts offer explicit exact-resource approval until close or remembered for the same saved session. Match tool, operation, agent, mode, request-policy context fingerprint, roots and file backend. Normal hard-deny checks still run before any reuse. Native ApprovalManager receives only ONCE approvals; no broad native SESSION/PATTERN/global grants are created. Process/network/delete operations remain one-shot. /permissions shows counts; /permissions reset revokes retained grants. Cancelled/denied requests never create grants.
Depends on #156 (real permission wire fix). No PRs merged.
Validation
10 focused grant/child-approval tests pass, including actual ToolManager writes, policy denial, exact literal-path/agent separation, close/reload/revocation, forged unsafe choices, cancellation/late reply, and real CLI persisted-choice roundtrip. Aggregate118 tests:117 pass; one fails in the independently reproduced native Windows atomic-save issue being fixed separately. Scoped Ruff/diff checks pass. Added to the ACP CI matrix.
Session metadata is the local persistence trust boundary; this is not protection from privileged local filesystem tampering.