Skip to content

Fix #645: Rebranded Illogical Scenario Modifiers; Re-Enabled Ambush Modifiers - #646

Open
IllianiBird wants to merge 2 commits into
MegaMek:mainfrom
IllianiBird:scenarioModifierRebranding
Open

IllianiBird wants to merge 2 commits into
MegaMek:mainfrom
IllianiBird:scenarioModifierRebranding

Conversation

@IllianiBird

@IllianiBird IllianiBird commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Fix #645

As per title


  • The source is cited above, or this is not a canon change
  • The changed entries were loaded in the program and look right
  • Every file in the diff has a deliberate change (no stray reformatting of untouched entries)
  • Dev team only: if AI tools were used, the AI Assisted Development label is applied, and I can
    explain and have verified the result

@IllianiBird IllianiBird self-assigned this Oct 22, 2026

@VicenteCartas VicenteCartas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Blocker: missing comma in both manifests
    In both modifiermanifest.json and groundBattleModifiers.json, the new entry has no trailing comma.

  2. Minor: in-progress Garrison Duty contracts lose their turret defenders
    Existing saves store facility local modifiers by filename, such as LocalGarrisonTurrets.json from Garrison Duty. The turrets file is still on disk but no longer in the manifest, and the boats and infantry files are deleted. The game handles this correctly, but just raising it in case it was not expected.

  3. Can princess handle this?
    The ambush modifiers were disabled because of the comment "until Princess can better manage Hidden units". That's the case now with all Hammer changes?

@IllianiBird

Copy link
Copy Markdown
Contributor Author
  1. I'll take a look on Monday
  2. I don't think that's how that works, unless I'm completely forgetting an interaction
  3. Yeah, Hammer did updates to it earlier in the cycle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Issue] Planetary Garrison Infantry are hostile to player, even in situations where that doesn't make sense

2 participants