Repository navigation
Fix #645: Rebranded Illogical Scenario Modifiers; Re-Enabled Ambush Modifiers - #646
Open
IllianiBird wants to merge 2 commits into
Open
IllianiBird wants to merge 2 commits into
IllianiBird wants to merge 2 commits into
Conversation
…mbush Modifiers
5 tasks done
VicenteCartas
requested changes
Oct 23, 2026
VicenteCartas
left a comment
Contributor
There was a problem hiding this comment.
-
Blocker: missing comma in both manifests
In both modifiermanifest.json and groundBattleModifiers.json, the new entry has no trailing comma. -
Minor: in-progress Garrison Duty contracts lose their turret defenders
Existing saves store facility local modifiers by filename, such as LocalGarrisonTurrets.json from Garrison Duty. The turrets file is still on disk but no longer in the manifest, and the boats and infantry files are deleted. The game handles this correctly, but just raising it in case it was not expected. -
Can princess handle this?
The ambush modifiers were disabled because of the comment "until Princess can better manage Hidden units". That's the case now with all Hammer changes?
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #645
As per title
explain and have verified the result