Repository navigation
Conversation
- Add targeted positive/negative auth tests for pause, release, and early refund; negative tests assert the host Auth/InvalidAction error. - Re-enable missing_docs on the hand-written contract entrypoints while keeping the module-level allow for macro-generated items, and document escrow's set_treasury. - Drop stale orphan doc comments that broke cargo doc -D warnings. - Repair escrow test helpers so the suite builds on soroban-sdk 26 and the full escrow test suite passes.
|
@Darkvader-ship-it Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
@Darkvader-ship-it is attempting to deploy a commit to the chonilius' projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes escrow::pause has no test proving it requires the admin's authorization #547
closes #![warn(missing_docs)] is neutralised for every entrypoint by the module-wide #[allow(missing_docs)] #542
closes escrow::release has no test proving it requires the oracle's authorization #545
closes escrow::refund has no test proving it requires the admin's authorization #546
Add targeted positive/negative auth tests for pause, release, and early refund; negative tests assert the host Auth/InvalidAction error.
Re-enable missing_docs on the hand-written contract entrypoints while keeping the module-level allow for macro-generated items, and document escrow's set_treasury.
Drop stale orphan doc comments that broke cargo doc -D warnings.
Repair escrow test helpers so the suite builds on soroban-sdk 26 and the full escrow test suite passes.
Summary
Related issues
Changes
Test plan
make test)Checklist
maincargo fmtandcargo clippyare clean