Skip to content

IpmiClient timeout: cleanup runs alongside the still-running worker, and Close Session is never confirmed #132

Description

@bertysentry

Where: src/main/java/org/metricshub/ipmi/client/IpmiClient.java (try-with-resources around Utils.execute), src/main/java/org/metricshub/ipmi/client/Utils.java (execute), src/main/java/org/metricshub/ipmi/client/runner/AbstractIpmiRunner.java (close).

Context: Codex raised this on #124: Utils.execute() only bounds the runner's call(); the try-with-resources in each IpmiClient method then calls AbstractIpmiRunner.close() on the calling thread, after the deadline, so the cleanup is not covered by IpmiClientConfiguration.timeout.

What the code does today:

Suggested fix:

No documentation change is needed until this is fixed.

Related: #77 (per-message timeout), #78 (sync retry), #79 (cancellation, non-daemon threads).

Activity

  1. added a commit that references this issue on Oct 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions