Repository navigation
perf(property-list): memoize property list re-renders - #1285
Merged
nanaf6203-bit merged 2 commits intoOct 15, 2026
Merged
nanaf6203-bit merged 2 commits into
nanaf6203-bit merged 2 commits into
Conversation
|
@ameeribro4-sudo Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Optimizes re-renders of the PropertyList component so unchanged inputs no longer force the virtualized grid to rebuild its configuration or re-render its rows. The grid now skips work entirely when the parent re-renders with the same properties, view mode and class name.
Problem
VirtualizedPropertyGrid was exported as a plain function component, so any state change higher in the tree re-rendered it and every visible property card even when nothing it consumed had changed. On top of that, useVirtualizer was handed a fresh options object on every render, causing the virtualizer to be reconfigured each time regardless of whether its inputs had changed.
Changes Made
Implementation Details
Memoization is applied at the component boundary rather than to individual rows, which covers the common case of a parent re-rendering because of unrelated store or filter state while the result set itself is untouched. Row-level rendering logic, the column measurement effect and the public props interface were left as they were.
Closes #1177
Closes #1176
Closes #1175
Closes #1178