Skip to content

perf(property-list): memoize property list re-renders #1285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nanaf6203-bit merged 2 commits into from
Oct 15, 2026
Merged

perf(property-list): memoize property list re-renders #1285

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ae888c9
perf(property-list): memoize virtualized property grid
ameeribro4-sudo Oct 15, 2026
886296c
Merge branch 'main' into fix/issue-1177-optimize-property-list-renders
nanaf6203-bit Oct 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 14 additions & 7 deletions src/components/VirtualizedPropertyGrid.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
'use client';
import React, { useRef, useEffect, useState } from 'react';
import React, { memo, useMemo, useRef, useEffect, useState } from 'react';
import { useVirtualizer } from '@tanstack/react-virtual';
import { PropertyCard } from './PropertyCard';
import { ErrorBoundary } from './ui/SimpleErrorBoundary';
Expand Down Expand Up @@ -37,12 +37,19 @@ const VirtualizedPropertyGridInner: React.FC<VirtualizedPropertyGridProps> = ({

const rowCount = Math.ceil(properties.length / columns);

const rowVirtualizer = useVirtualizer({
count: rowCount,
getScrollElement: () => parentRef.current,
estimateSize: () => (viewMode === 'grid' ? 450 : 200),
overscan: 5,
});
// Keep a stable options object so the virtualizer is only reconfigured when
// its inputs change instead of on every render of the grid.
const virtualizerOptions = useMemo(
() => ({
count: rowCount,
getScrollElement: () => parentRef.current,
estimateSize: () => (viewMode === 'grid' ? 450 : 200),
overscan: 5,
}),
[rowCount, viewMode]
);

const rowVirtualizer = useVirtualizer(virtualizerOptions);

return (
<div
Expand Down
Loading