Repository navigation
perf(property-list): memoize property list computations - #1286
Merged
nanaf6203-bit merged 2 commits intoOct 15, 2026
Merged
nanaf6203-bit merged 2 commits into
nanaf6203-bit merged 2 commits into
Conversation
|
@YaronZaki Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Memoizes the row-chunking computation in the PropertyList component so the visible listings are sliced out of the source array once per data change rather than on every render. This removes repeated array work from a component that sits directly in the search results render path.
Problem
VirtualizedPropertyGrid derived its row count with Math.ceil and then called properties.slice(...) again for every virtual row inside the render loop. Both calculations were re-executed on each render - including renders caused by unrelated filter, sort or pagination state - even though the property array and column count had not changed.
Changes Made
ows.length to useVirtualizer as the row count, which is numerically identical to the previous Math.ceil result.
ows array inside the virtual row map.
Implementation Details
The memoized chunk array is rebuilt only when the properties array reference or the measured column count changes, so scrolling and re-rendering now index into an existing structure. The fallback
ows[virtualRow.index] ?? [] keeps rendering safe if the virtualizer briefly reports an index beyond the current chunk list.
Closes #1186
Closes #1185
Closes #1184
Closes #1183