Skip to content

perf(property-list): memoize property list computations #1286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nanaf6203-bit merged 2 commits into from
Oct 15, 2026
Merged

perf(property-list): memoize property list computations #1286

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b3d5ce
perf(property-list): memoize property list row chunking
YaronZaki Oct 15, 2026
0bf7c4e
Merge branch 'main' into feat/issue-1186-memoize-property-list-comput…
nanaf6203-bit Oct 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions src/components/VirtualizedPropertyGrid.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,15 @@ const VirtualizedPropertyGridInner: React.FC<VirtualizedPropertyGridProps> = ({
return () => window.removeEventListener('resize', updateColumns);
}, [viewMode]);

const rowCount = Math.ceil(properties.length / columns);
// Chunk the listings once per (properties, columns) change instead of
// re-slicing the array for every virtual row on every render.
const rows = useMemo(() => {
const chunked: Property[][] = [];
for (let i = 0; i < properties.length; i += columns) {
chunked.push(properties.slice(i, i + columns));
}
return chunked;
}, [properties, columns]);

// Keep a stable options object so the virtualizer is only reconfigured when
// its inputs change instead of on every render of the grid.
Expand Down Expand Up @@ -70,8 +78,7 @@ const VirtualizedPropertyGridInner: React.FC<VirtualizedPropertyGridProps> = ({
className="list-none p-0 m-0"
>
{rowVirtualizer.getVirtualItems().map((virtualRow) => {
const startIndex = virtualRow.index * columns;
const itemsInRow = properties.slice(startIndex, startIndex + columns);
const itemsInRow = rows[virtualRow.index] ?? [];

return (
<li
Expand Down
Loading