Repository navigation
feat(property-list): improve empty state for property list - #1294
Merged
nanaf6203-bit merged 1 commit intoOct 15, 2026
Merged
Conversation
|
@1Judah Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Also repairs the virtualizer row count, which after the memoization refactor was left referencing the removed rowCount binding, to use the length of the chunked rows array.
1Judah
force-pushed
the
feat/issue-1180-improve-empty-state
branch
from
October 15, 2026 16:57
3f8342a to
80e732e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improves the empty state for the PropertyList component. When a listing search returns no results, the virtualized grid now renders a proper empty state with a heading, explanatory copy and a "Browse Properties" action instead of an empty scroll container.
This branch has been rebased onto the current
main, and while doing so it also repairs a broken reference in the same file: the virtualizer options were still reading therowCountbinding that the memoization refactor removed, leaving the grid referencing an undeclared variable. The row count now derives from the length of the chunkedrowsarray.Problem
VirtualizedPropertyGridalways rendered its scrollable container andullist, so a result set with zero properties produced a large blank region with anaria-labelannouncing "0 items" and nothing else. Users could not tell whether the search had failed, was still loading, or had genuinely returned nothing, and were given no route back to a full listing.Changes Made
PropertyEmptyStatehelper fromsrc/components/ui/EmptyState.tsxinsrc/components/VirtualizedPropertyGrid.tsx.PropertyEmptyStatewhenproperties.length === 0, passing the component'sclassNamethrough so surrounding layout spacing is preserved.countand its memo dependency from the removedrowCounttorows.length.Implementation Details
The early return is placed after the existing
useRef,useState,useEffect,useMemoanduseVirtualizercalls, so the rules of hooks are respected and the hook sequence is identical whether the grid is empty or not.rows.lengthis numerically equivalent to the previousMath.ceil(properties.length / columns)calculation and is already computed immediately above, so no extra work is introduced.PropertyEmptyStateis the shared empty-state component already used elsewhere in the app, which keeps the heading, description and call-to-action consistent with the rest of the search experience.Closes #1182
Closes #1181
Closes #1180
Closes #1179