Skip to content

feat(property-list): improve empty state for property list #1294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nanaf6203-bit merged 1 commit into from
Oct 15, 2026
+7 −2
Merged

feat(property-list): improve empty state for property list #1294

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/components/VirtualizedPropertyGrid.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import React, { memo, useMemo, useRef, useEffect, useState } from 'react';
import { useVirtualizer } from '@tanstack/react-virtual';
import { PropertyCard } from './PropertyCard';
import { ErrorBoundary } from './ui/SimpleErrorBoundary';
import { PropertyEmptyState } from './ui/EmptyState';
import type { Property } from '@/types/property';

interface VirtualizedPropertyGridProps {
Expand Down Expand Up @@ -49,16 +50,20 @@ const VirtualizedPropertyGridInner: React.FC<VirtualizedPropertyGridProps> = ({
// its inputs change instead of on every render of the grid.
const virtualizerOptions = useMemo(
() => ({
count: rowCount,
count: rows.length,
getScrollElement: () => parentRef.current,
estimateSize: () => (viewMode === 'grid' ? 450 : 200),
overscan: 5,
}),
[rowCount, viewMode]
[rows.length, viewMode]
);

const rowVirtualizer = useVirtualizer(virtualizerOptions);

if (properties.length === 0) {
return <PropertyEmptyState className={className} />;
}

return (
<div
ref={parentRef}
Expand Down
Loading