Skip to content

Frame the Hubs menu and the worktree-deletion dialog in the selected tab's blue - #12

Merged
ZmeiGorynych merged 4 commits into
mainfrom
egor/blue-borders-hubs-menu-delete-dialog
Oct 21, 2026
Merged

ZmeiGorynych merged 4 commits into
mainfrom
egor/blue-borders-hubs-menu-delete-dialog

Conversation

@ZmeiGorynych

@ZmeiGorynych ZmeiGorynych commented Oct 20, 2026 •

Copy link
Copy Markdown
Member

Cosmetic only.

  • The Hubs menu (.hubs-list) and the worktree-deletion confirm dialog get border: 3px solid var(--accent); --accent is the selected tab's background.
  • The confirm dialog is shared with repo removal and host actions (restart / reinstall daemon). Those keep their thin grey border; only worktree deletion gets the frame, through a delete-worktree modifier class.
  • The Hubs list gets data-testid="hubs-list" (added to the e2e contract).

Tests

  • hubs.spec.ts: the open Hubs menu's computed border is 3px on every side, in the selected repo tab's computed background colour.
  • sidebar.spec.ts: the same for the worktree-deletion dialog, and a repo-removal dialog stays 1px and not blue.
  • Both fail without the CSS rule. Full suite: vitest 2422/2422, Playwright 179/179.

Summary by CodeRabbit

  • Style

    • Added a 3px accent-colored border to the open Hubs menu.
    • Added a 3px selected-tab-colored border to worktree deletion confirmation dialogs.
    • Kept repository removal confirmation dialogs at their existing 1px border style.
    • Borders now provide clearer visual distinction between related interface elements.
  • Tests

    • Added end-to-end coverage verifying border styling for the Hubs menu and confirmation dialogs.

…tab's blue

Both get a 3px border in --accent, the selected tab's background. The
confirm dialog is shared with repo removal and host actions; only the
worktree deletion gets the frame, via a delete-worktree modifier class.
@coderabbitai

coderabbitai Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: MotleyAI/worktree-term/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 79c92718-c5d4-45f0-84aa-d485b8fdf28f
📥 Commits

Reviewing files that changed from the base of the PR and between 36d8d4d and e7c31fc.

📒 Files selected for processing: 1
  • src/hub/links/hub.test.ts

Included review availability: This review used your included allowance. 3 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.

📝 Walkthrough

The Hubs menu and worktree-deletion confirmation dialog now receive 3px accent borders. End-to-end tests check their border widths and colors. Repository-removal dialogs retain 1px borders. The silent-run timeout test now accepts a 290 ms minimum.

Changes: Accent framing

Layer / File(s) Summary
Apply accent framing
src/web/ui/app.tsx, src/web/main/styles.css
The Hubs menu receives a test ID. Worktree-deletion dialogs receive a distinct CSS class. CSS applies 3px accent borders to both elements.
Verify accent framing
test/e2e/contract.ts, test/e2e/fixture.ts, test/e2e/hubs.spec.ts, test/e2e/sidebar.spec.ts
The test contract documents the framing. Fixture helpers read computed border styles and the selected tab color. End-to-end tests check the Hubs menu and deletion-dialog borders. An additional assertion checks remote repository-tab visibility before reload.

Silent-run timing

Layer / File(s) Summary
Adjust timeout expectation
src/hub/links/hub.test.ts
The silent-run timeout test now accepts elapsed time of at least 290 ms instead of 300 ms.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature

Merge Risk: ⚪ Minimal · up to e7c31

No actionable merge-blocking risk was identified in the reviewed changes.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the primary UI changes to the Hubs menu and worktree-deletion dialog.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 6…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 6 files.

✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

…test

The fragment is removed before the one-time code is exchanged, so a
reload in between left the page without a credential (1 in 20 runs).
A 300 ms timer can fire 1 ms early on the Date.now() clock (CI saw 299),
as the other time-limit tests already allow for.
@sonarqubecloud

Copy link
Copy Markdown

@ZmeiGorynych
ZmeiGorynych merged commit b9206f6 into main Oct 21, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant