Repository navigation
Frame the Hubs menu and the worktree-deletion dialog in the selected tab's blue - #12
Merged
Merged
Conversation
…tab's blue Both get a 3px border in --accent, the selected tab's background. The confirm dialog is shared with repo removal and host actions; only the worktree deletion gets the frame, via a delete-worktree modifier class.
…test The fragment is removed before the one-time code is exchanged, so a reload in between left the page without a credential (1 in 20 runs).
A 300 ms timer can fire 1 ms early on the Date.now() clock (CI saw 299), as the other time-limit tests already allow for.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Cosmetic only.
.hubs-list) and the worktree-deletion confirm dialog getborder: 3px solid var(--accent);--accentis the selected tab's background.delete-worktreemodifier class.data-testid="hubs-list"(added to the e2e contract).Tests
hubs.spec.ts: the open Hubs menu's computed border is 3px on every side, in the selected repo tab's computed background colour.sidebar.spec.ts: the same for the worktree-deletion dialog, and a repo-removal dialog stays 1px and not blue.Summary by CodeRabbit
Style
Tests