Repository navigation
Feature/ngs360 workflow pin version - #185
Open
maggiecbms wants to merge 2 commits into
Open
maggiecbms wants to merge 2 commits into
maggiecbms wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
NGS360Platform.copy_workflownow returns<uuid>:<version>instead of thebare workflow id, resolving the version the project is pinned to via
POST /projects/{id}/workflow-versions/{wf}/resolve(updated in NGS360/APIServer#474).Why
A bare workflow id leaves WES to pick the version, and it picks the highest one by default.
A project's results then change silently whenever a new version is registered or
the
prodalias moves. Resolving pins the version on first run and reuses itafter, so re-running months later submits the same version.
Explicit identifiers (
<uuid>:3) pass through untouched — a one-off run againsta specific version must not change what the project uses from then on.
Tests
Six tests in
tests/test_ngs360_ga4gh_platform.pycover first use, reuse afterthe alias moves, explicit-version passthrough, the two raise paths, and that
task-reuse matching still works with the
:versionsuffix.