Repository navigation
feat:Prometheus metric cardinality guard for user-controlled label va… - #708
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds documentation comments to the WhatsApp user service. This is a comment-only change with no functional or behavioral differences.
Changes
Notes for reviewers
While documenting, I added
NOTEcomments on two existing issues. I did not fix them here:generateOtpusesMath.random(), which isn't cryptographically secure.crypto.randomIntwould be a safer choice.verifyOtpdoesn't limit failed attempts, so a 6-digit code could be brute-forced within its 5-minute TTL.Also worth knowing:
decrementBalancesilently clamps to 0 on overdraw instead of throwing.I'm happy to open follow-up PRs for these.
Testing
No code changes, so no new tests. Existing tests and the build are unaffected.
Closes #660
Closes #661
Closes #659
Closes #679