Repository navigation
Conversation
|
@bugstan is attempting to deploy a commit to the Together AI Team on Vercel. A member of the Team first needs to authorize it. |
Collaborator
|
Thanks @bugstan, both bugs were real and the second one would have failed CI on main. We fixed them a little differently: sloplint now exits 2 only when a path you passed on the command line can't be read (so one broken symlink deep in a project doesn't stop the whole run), and the theme index no longer writes a |
timothybrush
pushed a commit
to timothybrush/hallmark
that referenced
this pull request
Oct 27, 2026
…index carries no build date, so the index check passes on any day From the report in Nutlope#89. Co-authored-by: bugstan <29607505+bugstan@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix two reproducible CLI/check failures in separate commits.
sloplintpreviously printedcannot readfor a missing input but returned success if another input was clean.--beforealso wrote an incomplete snapshot. It now exits 2 during file collection, before reporting or snapshot writes. Reproduce withnode skills/hallmark/scripts/sloplint.mjs valid.css missing.css --scope component --tier floor --json, wherevalid.csscontains/* Hallmark · component: text */followed byp { color: var(--color-text); }.The existing CI index-freshness check also failed on an unchanged checkout after the index's build day:
theme.mjs indexchanged onlybuilt, andgit diff --exit-coderejected it. Preserve the previous build date when the generated theme entries are identical. Changed entries still regenerate with the current date, and missing or malformed indexes still rebuild. The existing exact-diff CI check remains unchanged.Add regressions to the existing
refcheck.mjsrunner for clean and unreadable lint inputs, incomplete snapshots, stable index output across build dates, changed metadata, and index reconstruction. No new dependencies or workflow changes.Validation:
refcheck.mjsclean across 99 reference files; all 48 themes validate;theme.mjs indexfollowed bygit diff --exit-code -- skills/hallmark/references/themes/index.jsonpasses.--before, with no success report or partial snapshot.git diff --checkpasses.GitHub Actions for this external contribution requires maintainer approval; local verification does not claim a completed remote CI run.