Repository navigation
chore: [SDK-5532] add sticky log view to demo app - #74
Merged
Merged
Conversation
nan-li
approved these changes
Oct 13, 2026
Logcat-style panel under the app bar showing SDK listener events, so the shared Appium suite can assert JS click and foregroundWillDisplay events. Notification events now include the notification id. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
fadi-george
force-pushed
the
fadi/sdk-5532
branch
from
October 13, 2026 17:17
2231d80 to
456004e
Compare
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
fadi-george
force-pushed
the
fadi/sdk-5532
branch
from
October 13, 2026 17:55
456004e to
9054f3f
Compare
sherwinski
approved these changes
Oct 13, 2026
7 of 18 tasks
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
fadi-george
changed the title
8 of 18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Add a logcat-style log view to the demo app that shows SDK listener events, so E2E tests can assert JS events.
Details
Motivation
The shared Appium suite (sdk-shared) needs a way to check that JS listeners fire, e.g. that a notification
clickfires exactly once after a cold-start or background tap. Device logs (logcat/syslog) are unreliable for this across wrappers and on real devices, so the demo shows events on screen where Appium can read them.This is the reference implementation for the other demos (SDK-5523) and follows the shared spec in
sdk-shared/demo/build.md(Prompt 1.5, 2.0, 6.2) andstyles.md(Log View).Scope
Demo app only; no SDK changes.
services/LogService.ts: in-memory log store (max 100 entries, never persisted) with alog()helper that also writes to the consolecomponents/LogView.tsx: sticky panel under the app bar with entry count, clear (trash) and collapse (chevron) buttons, auto-scroll to newesthooks/useOneSignal.ts: SDK listeners route throughlog(); notification click and foregroundWillDisplay now includenotificationIdlog_view,log_entry_{index},log_clear_button,log_toggle_buttonTesting
Unit testing
No new unit tests; demo UI only. Existing SDK tests pass (267/267).
Manual testing
On the Android 16 emulator: sent pushes from the demo while foregrounded and tapped them; the log view showed one
foregroundWillDisplayand oneclickentry with matching notification ids. Checked sticky behavior while scrolling, collapse/expand, and clear.Ran sdk-shared
run-local --platform=android --sdk=capacitor --spec=02with the new log assertions: 3/3 passing, assertions executed (not skipped).Affected code checklist
Checklist
Overview
Testing
Final pass
🤖 Generated with Claude Code