Repository navigation
Fix cached_clines accounting when moving invalid cache line - #988
Merged
Merged
Conversation
Only valid cache lines are accounted in cached_clines, and a line gets accounted to its current partition once it becomes valid. However ocf_user_part_move() moved the counter for every cache line, so moving a line that is mapped, but not valid (e.g. left mapped by a failed read miss for a request of another IO class waiting for it), underflowed the counter of the source partition and accounted the line twice in the destination one. Signed-off-by: Robert Baldyga <robert.baldyga@unvertical.com>
robertbaldyga
force-pushed
the
ioclass-stat-fix
branch
from
October 16, 2026 13:59
18dc6ed to
c123bfb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only valid cache lines are accounted in cached_clines, and a line gets accounted to its current partition once it becomes valid. However ocf_user_part_move() moved the counter for every cache line, so moving a line that is mapped, but not valid (e.g. left mapped by a failed read miss for a request of another IO class waiting for it), underflowed the counter of the source partition and accounted the line twice in the destination one.