Skip to content

Fix cached_clines accounting when moving invalid cache line #988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robertbaldyga merged 1 commit into from
Oct 16, 2026
Merged

Fix cached_clines accounting when moving invalid cache line #988

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions src/utils/utils_user_part.c
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
/*
* Copyright(c) 2012-2021 Intel Corporation
* Copyright(c) 2024 Huawei Technologies
* Copyright(c) 2026 Unvertical
* SPDX-License-Identifier: BSD-3-Clause
*/

Expand Down Expand Up @@ -156,10 +157,16 @@ void ocf_user_part_move(struct ocf_request *req)
part_counters[id_old].dirty_clines);
}

env_atomic_inc(&req->core->runtime_meta->
part_counters[id_new].cached_clines);
env_atomic_dec(&req->core->runtime_meta->
part_counters[id_old].cached_clines);
/* Only valid cache lines are accounted. A line that is mapped,
* but not valid yet, gets accounted to its current partition
* once it becomes valid.
*/
if (metadata_test_valid_any(cache, line)) {
env_atomic_inc(&req->core->runtime_meta->
part_counters[id_new].cached_clines);
env_atomic_dec(&req->core->runtime_meta->
part_counters[id_old].cached_clines);
}

/* DONE */
}
Expand Down
Loading