type-c-service/tps6699x: Fix EPR capable flag not being set - #938
Closed
RobertZ2011 wants to merge 1 commit into
Closed
type-c-service/tps6699x: Fix EPR capable flag not being set#938RobertZ2011 wants to merge 1 commit into
RobertZ2011 wants to merge 1 commit into
Conversation
RobertZ2011
force-pushed
the
stable-v0.1.y
branch
2 times, most recently
from
August 6, 2026 23:32
7dc74f3 to
b2e1585
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes PortStatus.epr reporting for the TPS6699x Type-C/PD controller integration by deriving the flag from the received Source Capabilities (Fixed Supply PDO) rather than leaving it unset. While doing so, it also switches dual_power and unconstrained_power extraction to use the decoded Fixed Supply PDO fields directly. A small documentation tweak updates the PortStatus comment to reflect that epr represents capability (not “mode active”).
Changes:
- Decode the first received source PDO as a Fixed Supply PDO and use it to populate
dual_power,unconstrained_power, andeprin sink explicit-contract status. - Add
PortStatus.eprassignment based onepr_capable. - Update the
PortStatusfield doc comment to “EPR capable”.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| type-c-service/src/driver/tps6699x.rs | Sets PortStatus.epr (and related partner-power flags) from the decoded Fixed Supply Source PDO when acting as a sink with an explicit contract. |
| embedded-service/src/type_c/controller.rs | Updates the documentation for PortStatus.epr to reflect capability semantics. |
This flag was not being set properly.
RobertZ2011
force-pushed
the
stable-v0.1.y
branch
from
August 6, 2026 23:37
b2e1585 to
7dc743d
Compare
RobertZ2011
marked this pull request as ready for review
August 6, 2026 23:38
RobertZ2011
requested review from
asasine,
gjpmsft,
jerrysxie,
kurtjd,
tullom and
williampMSFT
August 6, 2026 23:38
RobertZ2011
enabled auto-merge (squash)
August 6, 2026 23:38
kurtjd
approved these changes
Aug 7, 2026
Contributor
Author
|
Forgot to do this in a separate branch, moved to #941. |
auto-merge was automatically disabled
August 7, 2026 16:12
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This flag was not being set properly.