Skip to content

type-c-service/tps6699x: Fix EPR capable flag not being set #938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
RobertZ2011 wants to merge 1 commit into from
+9 −3
Closed

type-c-service/tps6699x: Fix EPR capable flag not being set #938

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion embedded-service/src/type_c/controller.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ pub struct PortStatus {
pub alt_mode: AltMode,
/// Power path status
pub power_path: PowerPathStatus,
/// EPR mode active
/// Port partner is EPR capable
pub epr: bool,
Comment thread
RobertZ2011 marked this conversation as resolved.
/// Port partner is unconstrained
pub unconstrained_power: bool,
Expand Down
10 changes: 8 additions & 2 deletions type-c-service/src/driver/tps6699x.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,13 +366,19 @@ impl<M: RawMutex, B: I2c> Controller for Tps6699x<'_, M, B> {
return Err(PdError::InvalidParams.into());
}

let source::Pdo::Fixed(fixed_source_pdo) = source_pdos[0] else {
error!("Port{}: First rx source PDO is not fixed", port.0);
return Err(PdError::InvalidParams.into());
};

let pdo = sink::Pdo::try_from(pdo_raw).map_err(|_| Error::from(PdError::InvalidParams))?;
let rdo = Rdo::for_pdo(rdo_raw, pdo).ok_or(Error::Pd(PdError::InvalidParams))?;
debug!("PDO: {:#?}", pdo);
debug!("RDO: {:#?}", rdo);
port_status.available_sink_contract = Contract::from_sink(pdo, rdo).try_into().ok();
port_status.dual_power = source_pdos[0].dual_role_power();
port_status.unconstrained_power = source_pdos[0].unconstrained_power();
port_status.dual_power = fixed_source_pdo.dual_role_power;
port_status.unconstrained_power = fixed_source_pdo.unconstrained_power;
port_status.epr = fixed_source_pdo.epr_capable;
}
} else if status.port_role() {
// port_role is true for source
Expand Down
Loading