Fix handling of GSAK multi DB backups - #947
Merged
AgreeDK merged 4 commits intoOct 1, 2026
Merged
Conversation
Member
|
@nagisml I've tested it locally, both on its own and merged on top of What I like:
A few things to consider (none of them blocking):
Needed before merge: this PR conflicts with #948 in I'll put |
Member
This was referenced Oct 1, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see #946
GSAK import: support multi-database backups
A GSAK backup
.zipholds onesqlite.db3per database (plusgsak.db3with the saved filters). Until now the import took only the first database and unpacked the whole backup to%TEMP%without removing it.Default-2is proposed instead).gsak.db3is present, offers the existing GSAK filter import afterwards..db3file or a zip with one database works as before (a one-row list).load_gsak_filters()never closedgsak.db3, which kept the file locked on Windows.Tested on a real 23-database / 9 GB backup; unit tests and mypy pass.