Skip to content

Feature/gpx export optimisations - #948

Merged
AgreeDK merged 3 commits into
OpenSAK-Org:betafrom
nagisml:feature/gpx-export-optimisations
Oct 1, 2026
Merged

AgreeDK merged 3 commits into
OpenSAK-Org:betafrom
nagisml:feature/gpx-export-optimisations

Conversation

@nagisml

@nagisml nagisml commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

nagisml and others added 3 commits September 30, 2026 21:40
…er tests

The quick-filter/filter-apply refresh runs on a background RefreshWorker
(OpenSAK-Org#740), so a 50ms qtbot.wait() raced the query on slow CI runners
(test_quick_filter_found_returns_zero saw 4 rows instead of 0).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@AgreeDK

AgreeDK commented Oct 1, 2026

Copy link
Copy Markdown
Member

@nagisml
Thanks, this looks really good! 👍

I've tested it locally, both on its own and merged on top of beta together with #947 and #949: the full unit suite passes (4410 tests) and mypy is clean.

What I like:

  • FileExportSettings.from_dict() falls back to defaults for missing or invalid keys, so saved settings keep loading when new options are added later. Nicely thought through.
  • The e2e fix uses the existing wait_for_refresh() helper from tests/data.py. That's the right approach, see below.

One observation, not a blocker: the new options (corrected coords on/off, max records) are only in the file export dialog, not in Send to GPS (gps_dialog.py). That's fine as scope for this PR, but users will probably ask for the same options there, so it might be worth a follow-up issue.

Merge order: all three of your open PRs (#947, #948, #949) change the same flaky test in tests/e2e-tests/test_e2e_filter.py, each in a slightly different way, so only the first one merges cleanly. Since this PR's version is the best one (it reuses wait_for_refresh()), I plan to merge this one first. I'll comment on the other two.

@AgreeDK
AgreeDK merged commit a2b9749 into OpenSAK-Org:beta Oct 1, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants