ci(gc): run the Windows try-root probe - #11755
Closed
proggeramlug wants to merge 2 commits into
Closed
proggeramlug wants to merge 2 commits into
proggeramlug wants to merge 2 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Oct 2, 2026
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows native-root CI currently requires the try/catch probe to fail compilation as a WinEH funclet. Current Perry emits a supported landing-pad path, so successful compilation trips the stale refusal check before the probe can execute.
Run the original try/catch probe on Windows through the same pinned-Node comparison and forced-evacuation matrix as the other targets. Require positive evacuation diagnostics and a measured RS4GC report with positive records and roots. The compiler guard and existing regression for genuine WinEH funclet IR remain unchanged.
This isolates the workflow correction from #11680. Its Rust code and the owner-reserved #11734 integration are not included. All compiler/runtime sources are byte-identical to main
b8a44f333e801d9e41a15cffe264d14280597c04.Local source validation: YAML parses, the changed matrix shell has valid syntax, evacuation-liveness self-tests and gate-wiring checks pass, and report controls accept a measured positive report while rejecting empty functions, a wrong backend, zero records, zero roots and unmeasured compact maps. These are parser controls, not an executed Windows probe.
Draft pending final-head full local lint, compiler/funclet-guard validation, and actual current-head Windows probe execution. No hosted CI or native execution success is claimed.
Refs #11560.
Current-head Windows execution at
443f9d0b58d5428a7ea67ddf14ba7d6e64f52089: the whole native-root job succeeded. The try/catch probe matched pinned Node26.5.1 under RS4GC and forced evacuation, with 76 actual copying minors and 3,545 objects copied. The try-specific report gate also accepted only RS4GC with positive emitted stackmap records and roots. All executed job steps succeeded. This is actual Windows execution, not parser-only evidence. The PR remains draft while final-head full lint, the compiler funclet-guard unit, and remaining target CI are pending.Current-head Linux target results: both Linux x64 and Linux ARM whole native-root jobs succeeded at this same head. Each try/catch probe performed 76 copying minors and moved 3,545 objects. Windows also succeeded as recorded above. macOS is still running; final full lint and the dedicated compiler funclet-guard unit remain pending.
The current-head macOS job has now completed. Its probe matrix, walker agreement, both non-default walkers and in-process RS4GC steps passed. The whole job failed in the provider dylib fixture link with five CoreFoundation and three Objective-C undefined symbols; this is not a whole macOS pass. The stdlib-provider link omits the framework flags already used for the runtime dylib build. A separate fix is being validated; this draft remains pending final full lint, the real funclet-refusal unit and remaining CI acceptance.