Repository navigation
Conversation
saveInformationAboutListing() stored the raw REQUEST_URI in the ga_last_listing cookie. With a long query string (listing filters, crawlers), the encrypted cookie went over 4096 bytes and Cookie threw while writing it, after the page was rendered. The path, capped at 255 characters, is enough for HookDisplayFooterProduct to match the product page referer.
|
Hello @boo-code! This is your first pull request on ps_googleanalytics repository of the PrestaShop project. Thank you, and welcome to this Open Source community! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
saveInformationAboutListing()stored the rawREQUEST_URIin thega_last_listingcookie on every product listing. With a long query string (filter modules, crawlers), the encrypted cookie went over 4096 bytes andCookiethrew "Combined size of name and value cannot exceed 4096 characters" while writing it, after the page was rendered.Only the path is stored now, capped at 255 characters.
HookDisplayFooterProductusesitem_list_urlonly to check that the product page referer contains it, which the listing path still does.item_list_id: "category"anditem_list_name: "Category: Clothes", and a product opened from another page sends none.