Skip to content

Store only the listing path in the last listing cookie #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
boo-code wants to merge 1 commit into
base: dev
Choose a base branch
from
+3 −1
Open

Store only the listing path in the last listing cookie #188

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion classes/Hook/HookDisplayBeforeBodyClosingTag.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,8 +250,10 @@ private function saveInformationAboutListing()
}

// Save this information to a cookie
// WHY: the query string is left out, listing filters can make it long enough for the cookie to exceed
// the 4096 bytes Cookie accepts, and Cookie then throws. The path still matches the product page referer.
$this->context->cookie->ga_last_listing = json_encode([
'item_list_url' => $_SERVER['REQUEST_URI'],
'item_list_url' => substr(strtok($_SERVER['REQUEST_URI'], '?'), 0, 255),
'item_list_id' => $this->context->controller->php_self,
'item_list_name' => $listing['label'],
]);
Expand Down
Loading