Language: weak typed int TypeError on INF/NAN (#27925) - #27962
Merged
Conversation
Match zend_dval_to_lval_safe: non-finite floats reject for typed int params/returns/properties and Z_PARAM_LONG (chr), while (int)/intval stay 0. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
int(params, returns, properties) andchr()/Z_PARAM_LONGnowTypeErroronINF/-INF/NAN, matchingzend_dval_to_lval_safe.(int)/intval()still truncate to0; finite float→int still emitsE_DEPRECATED(Language: float→int typed-param coerce silent — Zend E_DEPRECATED precision loss (zend_operators.c) #23533).lib/VM/TypeCheck,lib/JIT/*,ext/standard/VmMath/JitIntdiv/JitChr).Closes #27925
Test plan
TypeErrorlines0f(1.5)still deprecates + truncatesTypedIntNonfiniteTypeErrorVMTest/JITTestVerification transcript
Trust snapshot (pre-claim)
bootstrap-inventory --check: OK 7078/7078release-readiness --json:user_release_ready: no— first failnorth-star5-fast(gen-0 manifest/driver mismatch Self-host M5: bootstrap-inventory argv driver size floor — grow beyond 451KB stub #8713); unrelated to this language fixMade with Cursor