Skip to content

fix: report unknown product families in device info - #1029

Merged
Lash-L merged 2 commits into
Python-roborock:mainfrom
hCoureau:fix/unknown-product-family-export
Nov 15, 2026
Merged

Lash-L merged 2 commits into
Python-roborock:mainfrom
hCoureau:fix/unknown-product-family-export

Conversation

@hCoureau

Copy link
Copy Markdown
Contributor

roborock get-device-info currently exports PEARLPLUS for unrecognized product models because it uses the runtime family fallback. Look up the model mapping directly so these exports report Unknown, while mapped models retain their existing family names. Correct the same stale labels in the device catalogue for sc05, a288, and ss07.

Validation: 81 CLI and supported-feature tests, offline verification that only those three catalogue values changed, the full default suite on Python 3.14 (2,283 passed; 53 xfailed), all pre-commit checks and commitlint. Source/wheel builds passed for the CLI change; the catalogue is excluded from those packages. All 11 real-broker MQTT tests pass on the combined changes on Python 3.11 and 3.14. The production get-device-info command was also run against the Qrevo 2 Pro using an authenticated cache scoped in memory to that device: live capability replies were received and the export reported Unknown. Account cache files and device settings were unchanged.

@hCoureau
hCoureau marked this pull request as ready for review November 10, 2026 22:11
infy1995 added a commit to infy1995/python-roborock that referenced this pull request Nov 11, 2026
Keep the B01 snapshots and exclude only A01 devices, which report
their features on a data point. Report the F25 Ultra family as Unknown
in device_info.yaml, matching what get-device-info exports for
unmapped models after Python-roborock#1029.
@Lash-L Lash-L added Small PR Small pull request (<200 lines) bug Something isn't working V1 V1 platform labels Nov 15, 2026

@Lash-L Lash-L left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change - ty!

@Lash-L
Lash-L merged commit fe38922 into Python-roborock:main Nov 15, 2026
9 checks passed
@hCoureau
hCoureau deleted the fix/unknown-product-family-export branch November 16, 2026 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Small PR Small pull request (<200 lines) V1 V1 platform

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants