Repository navigation
fix(release): read manifest.json as UTF-8 when packaging - #82
Merged
Merged
Conversation
…hon defaults to cp1252)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v1.0.3 release run showed why the Windows archive was named 1.0.0 in 1.0.2: Python on the Windows runner opens
manifest.jsonas cp1252 and fails on the Cyrillic description (UnicodeDecodeError); the old script swallowed the error and fell back to 1.0.0. #80 made that failure loud; this reads the file as UTF-8. The tagv1.0.3is moved to the merge commit afterwards.