Skip to content

fix(release): read manifest.json as UTF-8 when packaging #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ZhuchkaTriplesix merged 1 commit into from
Oct 25, 2026
Merged

fix(release): read manifest.json as UTF-8 when packaging #82

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion scripts/package_qext.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,9 @@ else
fi

# Extract version from manifest.json using Python (works reliably across platforms)
VERSION=$("$PY" -c "import json; print(json.load(open('manifest.json'))['version'])")
# utf-8 explicitly: the manifest has Cyrillic text, and Windows Python reads
# files as cp1252 by default (that was the real cause of the silent 1.0.0).
VERSION=$("$PY" -c "import json; print(json.load(open('manifest.json', encoding='utf-8'))['version'])")
if [ -z "$VERSION" ]; then
echo "❌ Error: could not read the version from manifest.json."
exit 1
Expand Down
Loading