Skip to content

feat: add and use focus color #1667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maxelkins wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat: add and use focus color #1667

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d5cada7
feat: add a focus color
maxelkins Sep 29, 2026
dbdbd38
fix: use editor-focus-color
maxelkins Sep 29, 2026
134ceca
refactor: remove unused custom property
maxelkins Sep 29, 2026
a9a7907
refactor: replace all focus uses of `$rpf-brand-raspberry` with new `…
maxelkins Sep 29, 2026
3c127e9
refactor: replace all focus uses of `--rpf-brand-raspberry` with new …
maxelkins Sep 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions src/assets/stylesheets/Button.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
}

&:focus-visible {
border: 3px solid $rpf-brand-raspberry;
border: 3px solid var(--editor-focus-color);
outline: none;
}

Expand Down Expand Up @@ -219,10 +219,11 @@
&:focus-visible {
background-clip: padding-box;
border: 2px solid transparent;
outline: 3px solid $rpf-brand-raspberry;
outline: 3px solid var(--editor-focus-color);
}

&.btn--secondary, &.btn--secondary:hover {
&.btn--secondary,
&.btn--secondary:hover {
border-color: var(--rpf-alert-error);
--rpf-button-secondary-border-color-hover: var(--rpf-alert-error);
}
Expand Down Expand Up @@ -276,7 +277,7 @@
outline: none;

.btn {
border: 3px solid $rpf-brand-raspberry;
border: 3px solid var(--editor-focus-color);
}
}

Expand Down Expand Up @@ -308,7 +309,7 @@
--rpf-button-primary-text-color: var(--rpf-white);

// Secondary
--rpf-button-secondary-background-color-focus: var(--rpf-brand-raspberry);
--rpf-button-secondary-background-color-focus: var(--editor-focus-color);
--rpf-button-secondary-background-color-hover: var(
--editor-color-theme-tertiary
);
Expand Down Expand Up @@ -340,7 +341,7 @@
--rpf-button-primary-text-color: var(--rpf-black);

// Secondary
--rpf-button-secondary-background-color-focus: var(--rpf-brand-raspberry);
--rpf-button-secondary-background-color-focus: var(--editor-focus-color);
--rpf-button-secondary-background-color-hover: var(--editor-color-outline);
--rpf-button-secondary-background-color-active: var(--rpf-navy-200);
--rpf-button-secondary-background-color-disabled: var(--editor-color-layer-3);
Expand Down
2 changes: 1 addition & 1 deletion src/assets/stylesheets/EditorPanel.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
position: absolute;
z-index: 201;
inset: 4px;
outline: 4px solid var(--rpf-input-outline-color);
outline: 4px solid var(--editor-focus-color);
pointer-events: none;
}

Expand Down
4 changes: 2 additions & 2 deletions src/assets/stylesheets/Global.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,15 +14,15 @@

a:not(:where(.rpf-button)) {
&:focus-visible {
outline: 3px solid var(--rpf-raspberry-800);
outline: 3px solid var(--editor-focus-color);
}
}

button:not(:where(.rpf-button)) {
all: initial;
cursor: pointer;
&:focus-visible {
outline: 3px solid var(--rpf-raspberry-800);
outline: 3px solid var(--editor-focus-color);
}
}

Expand Down
2 changes: 1 addition & 1 deletion src/assets/stylesheets/HtmlRunner.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ a.htmlrunner-link {

&:focus-visible {
background-color: inherit;
border: 3px solid $rpf-brand-raspberry;
border: 3px solid var(--editor-focus-color);
outline: none;
}

Expand Down
2 changes: 1 addition & 1 deletion src/assets/stylesheets/Instructions.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,7 +349,7 @@
border: 0;

&:focus-visible {
border: 3px solid $rpf-brand-raspberry;
border: 3px solid var(--editor-focus-color);
outline: none;
}
}
Expand Down
3 changes: 2 additions & 1 deletion src/assets/stylesheets/InternalStyles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@
--editor-color-text: var(--rpf-text-primary);
--editor-color-text-secondary: var(--rpf-text-secondary);
--editor-color-tab-background: var(--rpf-off-white);
--editor-focus-color: var(--rpf-raspberry-800);

--rpf-files-list-item-active: var(--editor-color-theme-tertiary);
--rpf-files-list-item-hover: var(--editor-color-theme-tertiary);
Expand Down Expand Up @@ -88,6 +89,7 @@
--editor-color-theme-tertiary: var(--rpf-navy-900);
--editor-color-text: var(--rpf-white);
--editor-color-text-secondary: var(--rpf-text-secondary-darkmode);
--editor-focus-color: var(--rpf-raspberry-800);

--rpf-files-list-item-active: var(--editor-color-layer-2);
--rpf-files-list-item-hover: var(--editor-color-layer-2);
Expand Down Expand Up @@ -151,7 +153,6 @@
white 30%
);

--rpf-button-background-color-focus: var(--editor-color-theme);

@maxelkins maxelkins Sep 29, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked, this is not being used anywhere across the foundation for styles.

--rpf-button-background-color-disabled: var(--rpf-grey-500);

// Some parts of the button are not currently themeable via dedicated custom properties yet
Expand Down
2 changes: 1 addition & 1 deletion src/assets/stylesheets/Modal.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
}

&:focus-visible {
border: 3px solid $rpf-brand-raspberry;
border: 3px solid var(--editor-focus-color);
outline: none;
}
}
Expand Down
2 changes: 1 addition & 1 deletion src/assets/stylesheets/SelectButtons.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,5 +82,5 @@
}

.select-buttons__button:focus-visible + .select-buttons__label {
outline: 3px solid $rpf-brand-raspberry;
outline: 3px solid var(--editor-focus-color);
}
4 changes: 2 additions & 2 deletions src/assets/stylesheets/Tabs.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@

&:focus-visible {
outline-offset: -3px;
outline: 3px solid $rpf-brand-raspberry;
outline: 3px solid var(--editor-focus-color);
}

&:focus:after {
Expand Down Expand Up @@ -87,7 +87,7 @@
border: 0;

svg {
border: 3px solid $rpf-brand-raspberry;
border: 3px solid var(--editor-focus-color);
}
}
}
Expand Down
Loading