Skip to content

French translation improvements - #443

Merged
Razeeman merged 32 commits into
Razeeman:devfrom
ldmpub:dev
Sep 20, 2026
Merged

Razeeman merged 32 commits into
Razeeman:devfrom
ldmpub:dev

Conversation

@ldmpub

@ldmpub ldmpub commented Jan 31, 2026

Copy link
Copy Markdown
Contributor

Hi,

New proposals.

Translation is complex (due to the impressive number of app features + lack of documentation + some 'strange' behavior and quite bad initial french translation, the 2 last items prevent to test and learn easily 😇).

Feel free not to include these proposals in "this week-end" release ... there is no hurry.

@ldmpub

ldmpub commented Feb 11, 2026

Copy link
Copy Markdown
Contributor Author

@Razeeman: Translation (french) improved and ready to be reviewed ...

@ldmpub ldmpub left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments to request several "translation strings".

Comment thread resources/src/main/res/values-fr/strings.xml
Comment thread resources/src/main/res/values-fr/strings.xml
@Razeeman

Copy link
Copy Markdown
Owner

Hello! Thank you again for the help. Will review the changes.

Comment thread resources/src/main/res/values-fr/strings.xml
Comment thread resources/src/main/res/values-fr/strings.xml
Comment thread resources/src/main/res/values-fr/strings.xml Outdated
Comment thread resources/src/main/res/values-fr/strings.xml Outdated
Comment thread resources/src/main/res/values-fr/strings.xml Outdated
@ldmpub

ldmpub commented Sep 12, 2026

Copy link
Copy Markdown
Contributor Author

Trying to close this old issue.

@Razeeman

Copy link
Copy Markdown
Owner

Hello! That should we do with this issue? There are still some conversations opened.

@ldmpub ldmpub left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Full review done.

Hope it's fine for you and that a new release is planned in the coming weeks.

Note: I'm more confident with the app UI now 😅.

@ldmpub

ldmpub commented Sep 13, 2026

Copy link
Copy Markdown
Contributor Author

PR to fix ktlint typo => #496

@Razeeman
Razeeman merged commit 48fd3d5 into Razeeman:dev Sep 20, 2026
1 check failed
@Razeeman

Copy link
Copy Markdown
Owner

Thank you!

@Razeeman

Copy link
Copy Markdown
Owner

Review from agent:

  • [P1] statistics_detail_total_duration is mistranslated as “Écart”.
    resources/src/main/res/values-fr/strings.xml:536
    This label describes the total duration, including when no comparison
    exists. “Écart” means difference/deviation. Keep Total or use Durée totale.

    Changed back to Total.

  • [P2] change_record_type_goal_time_hint should remain singular.
    resources/src/main/res/values-fr/strings.xml:206
    The resource labels one Goal subtype in several places, including the
    individual goal-statistics section. Changing Objectif to Objectifs makes
    those screens incorrect. A separate plural resource would be needed for the
    Goals tab.

    Changed back to Objectif.

  • [P3] Minor terminology note: time_second should normally remain the standard unit
    symbol s, rather than sec.

    Changed back to m and s.

@ldmpub

ldmpub commented Sep 20, 2026

Copy link
Copy Markdown
Contributor Author

Hi,

- P1 "Total" in stats => see new proposal done here using 'Solde': /pull/493

- P2 => Ok for singular but I agree with the agent:

A separate plural resource would be needed for the Goals tab

  • P3 According to the International System of Units (SI /NIST), the official symbols are lower-case letters:
    • Minutes: min
    • Seconds: s (or sec in non-formal contexts)
      I personally find "min / sec" more easy to understand without being much longer 👌,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants