Repository navigation
Support trusted mod PCM on the guest audio clock and prompt snapshots - #767
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tomba 2's Mario costume needs imported voice PCM to advance with the guest SPU clock, including muted, fast and rollback-suppressed output. Add trusted PCM callbacks after synthesis and before capture/host mute, with plugin context and plan-reset cleanup. Poll staged user snapshots before amortized interrupt-maintenance returns so short actions/voices can be captured while retaining the existing snapshot safety gates.
Validation on framework 97c9aa4 over frozen master 3db41f8: host_snapshot_guard, mod_runtime, spu_end_without_repeat and spu_guest_clock tests pass. The integrated Tomba 2 build passes 22 real gameplay/voice/current-build save-load assertions and native memory-card restoration. Its production executable measures 59.91 guest VBlanks/s for both Tomba and Mario with the owner-approved wall-clock presentation profile. The original-disc cache audits every one of 54 recipes from 29 images; these are guarded candidates, not a full-coverage claim.
Title integration: mstan/Tomba2Recomp#26. Tracking: beads-hal6. Owner accepted the production gameplay and authorized the merge. No cross-build or peer compatibility claim.