Repository navigation
fix: detect breakthroughs below wall-check tolerance - #13
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Side/floor breakthroughs with
wall_thickness=0.02and touching cavities withfigure_gap=0.04previously passed because the fixed 0.05 mm allowance erased the target. Cap the allowance at half each target so missing walls produce findings and the CLI returns exit code 3. Small positive targets remain supported; the README documents the policy.When a cylinder's conservative radial estimate would fail, measure its actual polygon side planes to preserve intact thin walls, including cylinders with odd segment counts. Reuse the existing finding schema and English/German messages.
Validation:
requirements-dev.txt: fullpytest -q— 548 passed in 91.91 s.6351a94.git diff --checkpassed.OPE-7. No release or production changes.