Skip to content

fix: detect breakthroughs below wall-check tolerance - #13

Merged
Rigare merged 2 commits into
mainfrom
fix/small-wall-breakthroughs
Nov 12, 2026
Merged

Rigare merged 2 commits into
mainfrom
fix/small-wall-breakthroughs

Conversation

@Rigare

@Rigare Rigare commented Nov 11, 2026 •

Copy link
Copy Markdown
Owner

Side/floor breakthroughs with wall_thickness=0.02 and touching cavities with figure_gap=0.04 previously passed because the fixed 0.05 mm allowance erased the target. Cap the allowance at half each target so missing walls produce findings and the CLI returns exit code 3. Small positive targets remain supported; the README documents the policy.

When a cylinder's conservative radial estimate would fail, measure its actual polygon side planes to preserve intact thin walls, including cylinders with odd segment counts. Reuse the existing finding schema and English/German messages.

Validation:

  • 15 new regression cases measure exported and reloaded STLs: side/floor breakthroughs, CLI exit 3, touching/nearby pockets, valid tiny targets, normal 2 mm rounding, and intact/contact/breached cylinders with 64/65 segments.
  • Initial regression baseline: 5 failed, 2 passed. Final wall-check file: 47 passed.
  • Python 3.13.5, dependencies installed from requirements-dev.txt: full pytest -q — 548 passed in 91.91 s.
  • Pyrefly 1.4.1: 0 errors in changed Python files; full-project diagnostics exactly match the 32 errors on base commit 6351a94.
  • Independent code review found no blocking issue. git diff --check passed.
  • GitHub Actions: both pytest and Docker jobs passed, including the test image, runtime image, imports and health smoke check. Local Docker/Podman was unavailable.

OPE-7. No release or production changes.

@Rigare
Rigare merged commit 0afc1bb into main Nov 12, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant